fix: revert reset changes, reset on open state change instead

This commit is contained in:
Brayden Brayden
2024-03-10 09:36:54 +00:00
parent 6f958b9320
commit afe99e5ec9
2 changed files with 14 additions and 18 deletions

View File

@@ -1,4 +1,4 @@
import { useMemo } from 'react'; import { useEffect, useMemo } from 'react';
import { zodResolver } from '@hookform/resolvers/zod'; import { zodResolver } from '@hookform/resolvers/zod';
import { useForm } from 'react-hook-form'; import { useForm } from 'react-hook-form';
@@ -149,6 +149,11 @@ export const EnableAuthenticatorAppDialog = ({
} }
}; };
useEffect(() => {
// Reset the form when the Dialog open state changes
setupTwoFactorAuthenticationForm.reset();
}, [open, setupTwoFactorAuthenticationForm]);
return ( return (
<Dialog open={open} onOpenChange={onOpenChange}> <Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="w-full max-w-xl md:max-w-xl lg:max-w-xl"> <DialogContent className="w-full max-w-xl md:max-w-xl lg:max-w-xl">
@@ -197,14 +202,7 @@ export const EnableAuthenticatorAppDialog = ({
/> />
<DialogFooter> <DialogFooter>
<Button <Button type="button" variant="secondary" onClick={() => onOpenChange(false)}>
type="button"
variant="secondary"
onClick={() => {
onOpenChange(false);
setupTwoFactorAuthenticationForm.reset();
}}
>
Cancel Cancel
</Button> </Button>

View File

@@ -1,4 +1,4 @@
import { useMemo } from 'react'; import { useEffect, useMemo } from 'react';
import { zodResolver } from '@hookform/resolvers/zod'; import { zodResolver } from '@hookform/resolvers/zod';
import { useForm } from 'react-hook-form'; import { useForm } from 'react-hook-form';
@@ -92,6 +92,11 @@ export const ViewRecoveryCodesDialog = ({ open, onOpenChange }: ViewRecoveryCode
} }
}; };
useEffect(() => {
// Reset the form when the Dialog open state changes
viewRecoveryCodesForm.reset();
}, [open, viewRecoveryCodesForm]);
return ( return (
<Dialog open={open} onOpenChange={onOpenChange}> <Dialog open={open} onOpenChange={onOpenChange}>
<DialogContent className="w-full max-w-xl md:max-w-xl lg:max-w-xl"> <DialogContent className="w-full max-w-xl md:max-w-xl lg:max-w-xl">
@@ -138,14 +143,7 @@ export const ViewRecoveryCodesDialog = ({ open, onOpenChange }: ViewRecoveryCode
/> />
<DialogFooter> <DialogFooter>
<Button <Button type="button" variant="secondary" onClick={() => onOpenChange(false)}>
type="button"
variant="secondary"
onClick={() => {
onOpenChange(false);
viewRecoveryCodesForm.reset();
}}
>
Cancel Cancel
</Button> </Button>