blsmedia/bot
2
0
Fork 0
Code Activity

fix(editor): ♿️ Improve code editor readiness

Browse Source
This commit is contained in:
Baptiste Arnaud
2022-02-16 15:47:26 +01:00
parent d2ac13ba5f
commit daaa8a0a2d
2 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
apps/builder/assets/styles/codeMirror.css
View File

@@ -1,6 +1,6 @@
.cm-editor { .cm-editor {
height: 100%;
outline: 0px solid transparent !important; outline: 0px solid transparent !important;
height: 100%;
} }
.cm-scroller { .cm-scroller {

11
apps/builder/components/shared/CodeEditor.tsx
View File

@@ -53,7 +53,7 @@ export const CodeEditor = ({
if (!editorContainer.current) return if (!editorContainer.current) return
const updateListenerExtension = EditorView.updateListener.of((update) => { const updateListenerExtension = EditorView.updateListener.of((update) => {
if (update.docChanged && onChange) if (update.docChanged && onChange)
setPlainTextValue(update.state.doc.toJSON().join(' ')) setPlainTextValue(update.state.doc.toJSON().join('\n'))
}) })
const extensions = [ const extensions = [
updateListenerExtension, updateListenerExtension,
@@ -77,5 +77,12 @@ export const CodeEditor = ({
return editor return editor
} }
return <Box ref={editorContainer} data-testid="code-editor" {...props} /> return (
<Box
ref={editorContainer}
data-testid="code-editor"
h={isReadOnly ? 'auto' : '250px'}
{...props}
/>
)
} }