From c64afb7073267b1c2853aada92d7c9b4cd43586a Mon Sep 17 00:00:00 2001
From: Baptiste Arnaud <contact@baptiste-arnaud.fr>
Date: Mon, 28 Mar 2022 18:04:26 +0200
Subject: [PATCH] =?UTF-8?q?fix(editor):=20=F0=9F=90=9B=20Fix=20edge=20on?=
 =?UTF-8?q?=20item=20offset=20top=20on=20drop?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../components/shared/Graph/Nodes/ItemNode/ItemNodesList.tsx | 2 +-
 apps/builder/contexts/TypebotContext/actions/steps.ts        | 5 ++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/apps/builder/components/shared/Graph/Nodes/ItemNode/ItemNodesList.tsx b/apps/builder/components/shared/Graph/Nodes/ItemNode/ItemNodesList.tsx
index 18fc20c53..ff736ed8c 100644
--- a/apps/builder/components/shared/Graph/Nodes/ItemNode/ItemNodesList.tsx
+++ b/apps/builder/components/shared/Graph/Nodes/ItemNode/ItemNodesList.tsx
@@ -72,12 +72,12 @@ export const ItemNodesList = ({
     if (!isDraggingOnCurrentBlock) return
     const itemIndex = computeNearestPlaceholderIndex(e.pageY, placeholderRefs)
     e.stopPropagation()
+    setDraggedItem(undefined)
     createItem(draggedItem as ButtonItem, {
       blockIndex,
       stepIndex,
       itemIndex,
     })
-    setDraggedItem(undefined)
   }
   useEventListener(
     'mouseup',
diff --git a/apps/builder/contexts/TypebotContext/actions/steps.ts b/apps/builder/contexts/TypebotContext/actions/steps.ts
index 04cf96bde..0e87d19d0 100644
--- a/apps/builder/contexts/TypebotContext/actions/steps.ts
+++ b/apps/builder/contexts/TypebotContext/actions/steps.ts
@@ -117,9 +117,8 @@ const moveStepToBlock = (
   const items = stepHasItems(step) ? step.items : []
   items.forEach((item) => {
     const edgeIndex = typebot.edges.findIndex(byId(item.outgoingEdgeId))
-    edgeIndex !== -1
-      ? (typebot.edges[edgeIndex].from.blockId = blockId)
-      : (newStep.outgoingEdgeId = undefined)
+    if (edgeIndex === -1) return
+    typebot.edges[edgeIndex].from.blockId = blockId
   })
   if (step.outgoingEdgeId) {
     if (typebot.blocks[blockIndex].steps.length > stepIndex ?? 0) {