blsmedia/bot
2
0
Fork 0
Code Activity

🐛 (typebotLink) Fix n+1 variable fill

Browse Source 
Closes #1375
This commit is contained in:
Baptiste Arnaud
2024-03-26 19:25:03 +01:00
parent d0be29e257
commit c552fa7cc3
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
packages/bot-engine/blocks/logic/typebotLink/executeTypebotLink.ts
View File

@ -153,7 +153,7 @@ const addLinkedTypebotToState = async (
...linkedTypebot, ...linkedTypebot,
variables: fillVariablesWithExistingValues( variables: fillVariablesWithExistingValues(
linkedTypebot.variables, linkedTypebot.variables,
currentTypebotInQueue.typebot.variables state.typebotsQueue
), ),
}, },
resultId: isPreview resultId: isPreview
@ -204,13 +204,16 @@ const createResumeEdgeIfNecessary = (
const fillVariablesWithExistingValues = ( const fillVariablesWithExistingValues = (
emptyVariables: Variable[], emptyVariables: Variable[],
existingVariables: Variable[] typebotsQueue: SessionState['typebotsQueue']
): Variable[] => ): Variable[] =>
emptyVariables.map((emptyVariable) => { emptyVariables.map((emptyVariable) => {
const matchedVariable = existingVariables.find( let matchedVariable
(existingVariable) => existingVariable.name === emptyVariable.name for (const typebotInQueue of typebotsQueue) {
) matchedVariable = typebotInQueue.typebot.variables.find(
(v) => v.name === emptyVariable.name
)
if (matchedVariable) break
}
return { return {
...emptyVariable, ...emptyVariable,
value: matchedVariable?.value, value: matchedVariable?.value,