From b0d86bf38292a6811abd51995f54c4334867388a Mon Sep 17 00:00:00 2001
From: Baptiste Arnaud <baptiste.arnaud95@gmail.com>
Date: Thu, 22 Aug 2024 17:39:10 +0200
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7=20Avoid=20rollup=20bundle=20crash?=
 =?UTF-8?q?=20when=20dev=20mode?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Closes #1736
---
 packages/embeds/js/rollup.config.js     | 4 +++-
 packages/embeds/js/tsconfig.json        | 3 +--
 packages/embeds/nextjs/rollup.config.js | 4 +++-
 packages/embeds/nextjs/tsconfig.json    | 3 +--
 packages/embeds/react/rollup.config.js  | 4 +++-
 packages/embeds/react/tsconfig.json     | 3 +--
 6 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/packages/embeds/js/rollup.config.js b/packages/embeds/js/rollup.config.js
index 414497d7a..108f45270 100644
--- a/packages/embeds/js/rollup.config.js
+++ b/packages/embeds/js/rollup.config.js
@@ -36,7 +36,9 @@ const indexConfig = {
       extensions,
     }),
     typescriptPaths({ preserveExtensions: true }),
-    typescript(),
+    typescript({
+      noEmitOnError: !process.env.ROLLUP_WATCH,
+    }),
     postcss({
       plugins: [autoprefixer(), tailwindcss()],
       extract: false,
diff --git a/packages/embeds/js/tsconfig.json b/packages/embeds/js/tsconfig.json
index 223b55aa7..1c583257e 100644
--- a/packages/embeds/js/tsconfig.json
+++ b/packages/embeds/js/tsconfig.json
@@ -15,7 +15,6 @@
     "declarationMap": true,
     "outDir": "dist",
     "noEmit": false,
-    "emitDeclarationOnly": true,
-    "noEmitOnError": true
+    "emitDeclarationOnly": true
   }
 }
diff --git a/packages/embeds/nextjs/rollup.config.js b/packages/embeds/nextjs/rollup.config.js
index f14a3209b..e529b7c29 100644
--- a/packages/embeds/nextjs/rollup.config.js
+++ b/packages/embeds/nextjs/rollup.config.js
@@ -30,7 +30,9 @@ const indexConfig = {
       extensions,
     }),
     typescriptPaths({ preserveExtensions: true }),
-    typescript(),
+    typescript({
+      noEmitOnError: !process.env.ROLLUP_WATCH,
+    }),
     terser({ format: { preamble } }),
   ],
 }
diff --git a/packages/embeds/nextjs/tsconfig.json b/packages/embeds/nextjs/tsconfig.json
index c967f2a99..3ec6e043a 100644
--- a/packages/embeds/nextjs/tsconfig.json
+++ b/packages/embeds/nextjs/tsconfig.json
@@ -10,7 +10,6 @@
     "declaration": true,
     "declarationMap": true,
     "noEmit": false,
-    "emitDeclarationOnly": true,
-    "noEmitOnError": true
+    "emitDeclarationOnly": true
   }
 }
diff --git a/packages/embeds/react/rollup.config.js b/packages/embeds/react/rollup.config.js
index 9827a2da4..8555f3a96 100644
--- a/packages/embeds/react/rollup.config.js
+++ b/packages/embeds/react/rollup.config.js
@@ -30,7 +30,9 @@ const indexConfig = {
       extensions,
     }),
     typescriptPaths({ preserveExtensions: true }),
-    typescript(),
+    typescript({
+      noEmitOnError: !process.env.ROLLUP_WATCH,
+    }),
     terser({ format: { preamble } }),
   ],
 }
diff --git a/packages/embeds/react/tsconfig.json b/packages/embeds/react/tsconfig.json
index c967f2a99..3ec6e043a 100644
--- a/packages/embeds/react/tsconfig.json
+++ b/packages/embeds/react/tsconfig.json
@@ -10,7 +10,6 @@
     "declaration": true,
     "declarationMap": true,
     "noEmit": false,
-    "emitDeclarationOnly": true,
-    "noEmitOnError": true
+    "emitDeclarationOnly": true
   }
 }