From ad9be922555ce6eb0a32470811e27b6db25d55b6 Mon Sep 17 00:00:00 2001 From: Baptiste Arnaud Date: Fri, 4 Nov 2022 07:47:17 +0100 Subject: [PATCH] :bug: (settings) Allow meta tags in head element --- apps/viewer/pages/[[...publicId]].tsx | 7 ++++++- apps/viewer/playwright/tests/metadata.spec.ts | 6 ++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/apps/viewer/pages/[[...publicId]].tsx b/apps/viewer/pages/[[...publicId]].tsx index a079f4e89..da85d1f9a 100644 --- a/apps/viewer/pages/[[...publicId]].tsx +++ b/apps/viewer/pages/[[...publicId]].tsx @@ -47,7 +47,12 @@ export const getServerSideProps: GetServerSideProps = async ( url: `https://${forwardedHost ?? host}${pathname}`, customHeadCode: isDefined(headCode) && headCode !== '' - ? sanitizeHtml(headCode, { allowedTags: ['script', 'meta'] }) + ? sanitizeHtml(headCode, { + allowedTags: ['script', 'meta'], + allowedAttributes: { + meta: ['name', 'content'], + }, + }) : null, }, } diff --git a/apps/viewer/playwright/tests/metadata.spec.ts b/apps/viewer/playwright/tests/metadata.spec.ts index 1ee077e67..90b3d133c 100644 --- a/apps/viewer/playwright/tests/metadata.spec.ts +++ b/apps/viewer/playwright/tests/metadata.spec.ts @@ -17,6 +17,7 @@ test('Should correctly parse metadata', async ({ page }) => { title: 'Custom title', favIconUrl: 'https://www.baptistearno.com/favicon.png', imageUrl: 'https://www.baptistearno.com/images/site-preview.png', + customHeadCode: '', } await createTypebots([ { @@ -50,6 +51,11 @@ test('Should correctly parse metadata', async ({ page }) => { (document.querySelector('link[rel="icon"]') as any).getAttribute('href') ) ).toBe(customMetadata.favIconUrl) + expect( + await page.evaluate( + () => (document.querySelector('meta[name="author"]') as any).content + ) + ).toBe('John Doe') await expect( typebotViewer(page).locator( `input[placeholder="${defaultTextInputOptions.labels.placeholder}"]`