2
0

♻️ Change overflow:scroll to overflow:auto

This commit is contained in:
Baptiste Arnaud
2024-01-25 16:35:16 +01:00
parent 0f245b8e57
commit ab010657b2
29 changed files with 28 additions and 55 deletions

View File

@ -6,17 +6,6 @@
cursor: grabbing !important; cursor: grabbing !important;
} }
/* Hide scrollbar for Chrome, Safari and Opera */
.hide-scrollbar::-webkit-scrollbar {
display: none;
}
/* Hide scrollbar for IE, Edge and Firefox */
.hide-scrollbar {
-ms-overflow-style: none; /* IE and Edge */
scrollbar-width: none; /* Firefox */
}
/* * { /* * {
outline: 1px solid #f00 !important; outline: 1px solid #f00 !important;
opacity: 1 !important; opacity: 1 !important;

View File

@ -78,7 +78,7 @@ export const DropdownList = <T extends readonly any[]>({
</MenuButton> </MenuButton>
<Portal> <Portal>
<MenuList maxW="500px" zIndex={1500}> <MenuList maxW="500px" zIndex={1500}>
<Stack maxH={'35vh'} overflowY="scroll" spacing="0"> <Stack maxH={'35vh'} overflowY="auto" spacing="0">
{items.map((item) => ( {items.map((item) => (
<MenuItem <MenuItem
key={item as unknown as string} key={item as unknown as string}

View File

@ -34,7 +34,7 @@ export const GiphyPicker = ({ onSubmit }: GiphySearchFormProps) => {
/> />
<GiphyLogo w="100px" /> <GiphyLogo w="100px" />
</Flex> </Flex>
<Flex overflowY="scroll" maxH="400px"> <Flex overflowY="auto" maxH="400px">
<Grid <Grid
key={inputValue} key={inputValue}
onGifClick={(gif, e) => { onGifClick={(gif, e) => {

View File

@ -115,7 +115,7 @@ export const IconPicker = ({ onIconSelected }: Props) => {
<ColorPicker value={selectedColor} onColorChange={updateColor} /> <ColorPicker value={selectedColor} onColorChange={updateColor} />
</HStack> </HStack>
<Stack overflowY="scroll" maxH="350px" ref={scrollContainer} spacing={4}> <Stack overflowY="auto" maxH="350px" ref={scrollContainer} spacing={4}>
{recentIconNames.length > 0 && ( {recentIconNames.length > 0 && (
<Stack> <Stack>
<Text fontSize="xs" color="gray.400" fontWeight="semibold" pl="2"> <Text fontSize="xs" color="gray.400" fontWeight="semibold" pl="2">

View File

@ -155,7 +155,7 @@ export const UnsplashPicker = ({ imageSize, onImageSelect }: Props) => {
{error} {error}
</Alert> </Alert>
)} )}
<Stack overflowY="scroll" maxH="400px" ref={scrollContainer}> <Stack overflowY="auto" maxH="400px" ref={scrollContainer}>
{images.length > 0 && ( {images.length > 0 && (
<Grid templateColumns="repeat(3, 1fr)" columnGap={2} rowGap={3}> <Grid templateColumns="repeat(3, 1fr)" columnGap={2} rowGap={3}>
{images.map((image, index) => ( {images.map((image, index) => (

View File

@ -110,7 +110,7 @@ export const EmojiSearchableList = ({
placeholder={t('emojiList.searchInput.placeholder')} placeholder={t('emojiList.searchInput.placeholder')}
onChange={handleSearchChange} onChange={handleSearchChange}
/> />
<Stack ref={scrollContainer} overflow="scroll" maxH="350px" spacing={4}> <Stack ref={scrollContainer} overflowY="scroll" maxH="350px" spacing={4}>
{recentEmojis.length > 0 && ( {recentEmojis.length > 0 && (
<Stack> <Stack>
<Text fontSize="xs" color="gray.400" fontWeight="semibold" pl="2"> <Text fontSize="xs" color="gray.400" fontWeight="semibold" pl="2">

View File

@ -181,7 +181,7 @@ export const AutocompleteInput = ({
<Portal containerRef={parentModalRef}> <Portal containerRef={parentModalRef}>
<PopoverContent <PopoverContent
maxH="35vh" maxH="35vh"
overflowY="scroll" overflowY="auto"
role="menu" role="menu"
w="inherit" w="inherit"
shadow="lg" shadow="lg"

View File

@ -217,7 +217,7 @@ export const Select = <T extends Item>({
<Portal containerRef={parentModalRef}> <Portal containerRef={parentModalRef}>
<PopoverContent <PopoverContent
maxH="35vh" maxH="35vh"
overflowY="scroll" overflowY="auto"
role="menu" role="menu"
w="inherit" w="inherit"
shadow="lg" shadow="lg"

View File

@ -233,7 +233,7 @@ export const VariableSearchInput = ({
<Portal containerRef={parentModalRef}> <Portal containerRef={parentModalRef}>
<PopoverContent <PopoverContent
maxH="35vh" maxH="35vh"
overflowY="scroll" overflowY="auto"
role="menu" role="menu"
w="inherit" w="inherit"
shadow="lg" shadow="lg"

View File

@ -28,7 +28,7 @@ export const MyAccountForm = () => {
} }
return ( return (
<Stack spacing="6" w="full" overflowY="scroll"> <Stack spacing="6" w="full" overflowY="auto">
<HStack spacing={6}> <HStack spacing={6}>
<Avatar <Avatar
size="lg" size="lg"

View File

@ -152,7 +152,7 @@ export const ButtonsItemNode = ({ item, indices, isMouseOver }: Props) => {
<PopoverArrow bgColor={arrowColor} /> <PopoverArrow bgColor={arrowColor} />
<PopoverBody <PopoverBody
py="6" py="6"
overflowY="scroll" overflowY="auto"
maxH="400px" maxH="400px"
shadow="lg" shadow="lg"
ref={ref} ref={ref}

View File

@ -127,7 +127,7 @@ export const PictureChoiceItemNode = ({
<PopoverArrow /> <PopoverArrow />
<PopoverBody <PopoverBody
py="6" py="6"
overflowY="scroll" overflowY="auto"
maxH="400px" maxH="400px"
shadow="lg" shadow="lg"
ref={ref} ref={ref}

View File

@ -109,7 +109,7 @@ export const ConditionItemNode = ({ item, isMouseOver, indices }: Props) => {
<PopoverArrow /> <PopoverArrow />
<PopoverBody <PopoverBody
py="6" py="6"
overflowY="scroll" overflowY="auto"
maxH="400px" maxH="400px"
shadow="lg" shadow="lg"
ref={ref} ref={ref}

View File

@ -241,7 +241,7 @@ const CollaborationTypeMenuButton = ({
<ReadableCollaborationType type={type} /> <ReadableCollaborationType type={type} />
</MenuButton> </MenuButton>
<MenuList minW={0}> <MenuList minW={0}>
<Stack maxH={'35vh'} overflowY="scroll" spacing="0"> <Stack maxH={'35vh'} overflowY="auto" spacing="0">
<MenuItem onClick={() => onChange(CollaborationType.READ)}> <MenuItem onClick={() => onChange(CollaborationType.READ)}>
<ReadableCollaborationType type={CollaborationType.READ} /> <ReadableCollaborationType type={CollaborationType.READ} />
</MenuItem> </MenuItem>

View File

@ -116,7 +116,7 @@ export const CredentialsDropdown = ({
</Text> </Text>
</MenuButton> </MenuButton>
<MenuList> <MenuList>
<Stack maxH={'35vh'} overflowY="scroll" spacing="0"> <Stack maxH={'35vh'} overflowY="auto" spacing="0">
{defaultCredentialLabel && ( {defaultCredentialLabel && (
<MenuItem <MenuItem
maxW="500px" maxW="500px"

View File

@ -103,7 +103,7 @@ export const CustomDomainsDropdown = ({
</Text> </Text>
</MenuButton> </MenuButton>
<MenuList maxW="500px" shadow="lg"> <MenuList maxW="500px" shadow="lg">
<Stack maxH={'35vh'} overflowY="scroll" spacing="0"> <Stack maxH={'35vh'} overflowY="auto" spacing="0">
{(data?.customDomains ?? []).map((customDomain) => ( {(data?.customDomains ?? []).map((customDomain) => (
<Button <Button
role="menuitem" role="menuitem"

View File

@ -112,8 +112,7 @@ export const BlocksSideBar = () => {
bgColor={useColorModeValue('white', 'gray.900')} bgColor={useColorModeValue('white', 'gray.900')}
spacing={6} spacing={6}
userSelect="none" userSelect="none"
overflowY="scroll" overflowY="auto"
className="hide-scrollbar"
> >
<Flex justifyContent="flex-end"> <Flex justifyContent="flex-end">
<Tooltip <Tooltip

View File

@ -134,7 +134,7 @@ export const ForgedCredentialsDropdown = ({
</Text> </Text>
</MenuButton> </MenuButton>
<MenuList> <MenuList>
<Stack maxH={'35vh'} overflowY="scroll" spacing="0"> <Stack maxH={'35vh'} overflowY="auto" spacing="0">
{data?.credentials.map((credentials) => ( {data?.credentials.map((credentials) => (
<MenuItem <MenuItem
role="menuitem" role="menuitem"

View File

@ -69,7 +69,7 @@ export const SettingsPopoverContent = ({ onExpandClick, ...props }: Props) => {
<PopoverArrow bgColor={arrowColor} /> <PopoverArrow bgColor={arrowColor} />
<PopoverBody <PopoverBody
py="3" py="3"
overflowY="scroll" overflowY="auto"
maxH="400px" maxH="400px"
ref={ref} ref={ref}
shadow="lg" shadow="lg"

View File

@ -27,13 +27,7 @@ export const ApiPreviewInstructions = (props: StackProps) => {
}` }`
return ( return (
<Stack <Stack spacing={10} overflowY="auto" w="full" {...props}>
spacing={10}
overflowY="scroll"
className="hide-scrollbar"
w="full"
{...props}
>
<OrderedList spacing={6} px="1"> <OrderedList spacing={6} px="1">
<ListItem> <ListItem>
All your requests need to be authenticated with an API token.{' '} All your requests need to be authenticated with an API token.{' '}

View File

@ -68,8 +68,7 @@ export const WhatsAppPreviewInstructions = (props: StackProps) => {
<Stack <Stack
as="form" as="form"
spacing={4} spacing={4}
overflowY="scroll" overflowY="auto"
className="hide-scrollbar"
w="full" w="full"
px="1" px="1"
onSubmit={sendWhatsAppPreviewStartMessage} onSubmit={sendWhatsAppPreviewStartMessage}

View File

@ -71,7 +71,7 @@ const LogCard = ({ log }: { log: Log }) => {
</AccordionButton> </AccordionButton>
<AccordionPanel <AccordionPanel
as="pre" as="pre"
overflow="scroll" overflow="auto"
borderWidth="1px" borderWidth="1px"
borderRadius="md" borderRadius="md"
> >

View File

@ -232,7 +232,7 @@ export const ResultsTable = ({
</HStack> </HStack>
<Box <Box
ref={tableWrapper} ref={tableWrapper}
overflow="scroll" overflow="auto"
rounded="md" rounded="md"
data-testid="results-table" data-testid="results-table"
backgroundImage={`linear-gradient(to right, ${background}, ${background}), linear-gradient(to right, ${background}, ${background}),linear-gradient(to right, rgba(0, 0, 0, 0.1), rgba(255, 255, 255, 0)),linear-gradient(to left, rgba(0, 0, 0, 0.1), rgba(255, 255, 255, 0));`} backgroundImage={`linear-gradient(to right, ${background}, ${background}), linear-gradient(to right, ${background}, ${background}),linear-gradient(to right, rgba(0, 0, 0, 0.1), rgba(255, 255, 255, 0)),linear-gradient(to left, rgba(0, 0, 0, 0.1), rgba(255, 255, 255, 0));`}

View File

@ -68,13 +68,7 @@ const TableSettingsMenu = ({
switch (selectedMenu) { switch (selectedMenu) {
case 'columnSettings': case 'columnSettings':
return ( return (
<PopoverBody <PopoverBody as={Stack} spacing="4" p="4" maxH="450px" overflowY="auto">
as={Stack}
spacing="4"
p="4"
maxH="450px"
overflowY="scroll"
>
<ColumnSettings <ColumnSettings
resultHeader={resultHeader} resultHeader={resultHeader}
columnVisibility={columnVisibility} columnVisibility={columnVisibility}

View File

@ -56,7 +56,7 @@ export const SettingsSideMenu = () => {
borderRightWidth={1} borderRightWidth={1}
pt={10} pt={10}
spacing={10} spacing={10}
overflowY="scroll" overflowY="auto"
pb="20" pb="20"
> >
<Heading fontSize="xl" textAlign="center"> <Heading fontSize="xl" textAlign="center">

View File

@ -86,8 +86,7 @@ export const TemplatesModal = ({
borderRightWidth={1} borderRightWidth={1}
justify="space-between" justify="space-between"
flexShrink={0} flexShrink={0}
overflowY="scroll" overflowY="auto"
className="hide-scrollbar"
> >
<Stack spacing={5}> <Stack spacing={5}>
<Stack spacing={2}> <Stack spacing={2}>

View File

@ -65,7 +65,7 @@ export const ThemeSideMenu = () => {
borderRightWidth={1} borderRightWidth={1}
pt={10} pt={10}
spacing={10} spacing={10}
overflowY="scroll" overflowY="auto"
pb="20" pb="20"
position="relative" position="relative"
> >

View File

@ -98,7 +98,7 @@ const WorkspaceRoleMenuButton = ({
{convertWorkspaceRoleToReadable(role)} {convertWorkspaceRoleToReadable(role)}
</MenuButton> </MenuButton>
<MenuList minW={0}> <MenuList minW={0}>
<Stack maxH={'35vh'} overflowY="scroll" spacing="0"> <Stack maxH={'35vh'} overflowY="auto" spacing="0">
<MenuItem onClick={() => onChange(WorkspaceRole.ADMIN)}> <MenuItem onClick={() => onChange(WorkspaceRole.ADMIN)}>
{convertWorkspaceRoleToReadable(WorkspaceRole.ADMIN)} {convertWorkspaceRoleToReadable(WorkspaceRole.ADMIN)}
</MenuItem> </MenuItem>

View File

@ -139,8 +139,7 @@ export const WorkspaceSettingsModal = ({
size="sm" size="sm"
justifyContent="flex-start" justifyContent="flex-start"
pl="4" pl="4"
overflow="scroll" overflow="auto"
className="hide-scrollbar"
> >
{t('workspace.settings.modal.menu.billingAndUsage.label')} {t('workspace.settings.modal.menu.billingAndUsage.label')}
</Button> </Button>