2
0

🐛 (googleAnalytics) Fix output validation when using variable as event value

This commit is contained in:
Baptiste Arnaud
2023-05-03 18:09:25 -04:00
parent f2d31745ca
commit 65c6f66a5c
4 changed files with 27 additions and 24 deletions

View File

@@ -57,22 +57,24 @@ export const NumberInput = <HasVariable extends boolean>({
[onValueChangeDebounced]
)
const handleValueChange = (value: string) => {
setValue(value)
if (value.endsWith('.') || value.endsWith(',')) return
if (value === '') return onValueChangeDebounced(undefined)
const handleValueChange = (newValue: string) => {
if (value.startsWith('{{') && value.endsWith('}}') && newValue !== '')
return
setValue(newValue)
if (newValue.endsWith('.') || newValue.endsWith(',')) return
if (newValue === '') return onValueChangeDebounced(undefined)
if (
value.startsWith('{{') &&
value.endsWith('}}') &&
value.length > 4 &&
newValue.startsWith('{{') &&
newValue.endsWith('}}') &&
newValue.length > 4 &&
(withVariableButton ?? true)
) {
onValueChangeDebounced(value as Value<HasVariable>)
onValueChangeDebounced(newValue as Value<HasVariable>)
return
}
const newValue = parseFloat(value)
if (isNaN(newValue)) return
onValueChangeDebounced(newValue)
const numberedValue = parseFloat(newValue)
if (isNaN(numberedValue)) return
onValueChangeDebounced(numberedValue)
}
const handleVariableSelected = (variable?: Variable) => {

View File

@@ -158,15 +158,7 @@ export const BlockNodeContent = ({ block, indices }: Props): JSX.Element => {
)
}
case IntegrationBlockType.GOOGLE_ANALYTICS: {
return (
<GoogleAnalyticsNodeBody
action={
block.options?.action
? `Track "${block.options?.action}" `
: undefined
}
/>
)
return <GoogleAnalyticsNodeBody action={block.options?.action} />
}
case IntegrationBlockType.WEBHOOK: {
return <WebhookContent block={block} />