From 3e80af638b16d19e8522fc0887b26d1692c742bd Mon Sep 17 00:00:00 2001
From: Baptiste Arnaud <contact@baptiste-arnaud.fr>
Date: Mon, 28 Nov 2022 08:27:11 +0100
Subject: [PATCH] :pencil: Improve send email doc

---
 .../SendEmailSettings/SendEmailSettings.tsx         | 13 ++++++++++---
 apps/docs/docs/editor/blocks/integrations/email.mdx |  6 +++++-
 apps/docs/docs/embed/html-javascript.md             |  2 ++
 3 files changed, 17 insertions(+), 4 deletions(-)

diff --git a/apps/builder/src/features/blocks/integrations/sendEmail/components/SendEmailSettings/SendEmailSettings.tsx b/apps/builder/src/features/blocks/integrations/sendEmail/components/SendEmailSettings/SendEmailSettings.tsx
index 76691e6a8..a02b8a9e1 100644
--- a/apps/builder/src/features/blocks/integrations/sendEmail/components/SendEmailSettings/SendEmailSettings.tsx
+++ b/apps/builder/src/features/blocks/integrations/sendEmail/components/SendEmailSettings/SendEmailSettings.tsx
@@ -10,7 +10,7 @@ import {
 import { CodeEditor } from '@/components/CodeEditor'
 import { CredentialsType, SendEmailOptions, Variable } from 'models'
 import React, { useState } from 'react'
-import { env } from 'utils'
+import { env, isNotEmpty } from 'utils'
 import { SmtpConfigModal } from './SmtpConfigModal'
 import { SwitchWithLabel } from '@/components/SwitchWithLabel'
 import { VariableSearchInput } from '@/components/VariableSearchInput'
@@ -38,6 +38,7 @@ export const SendEmailSettings = ({ options, onOptionsChange }: Props) => {
     const recipients: string[] = recipientsStr
       .split(',')
       .map((str) => str.trim())
+      .filter(isNotEmpty)
     onOptionsChange({
       ...options,
       recipients,
@@ -45,7 +46,10 @@ export const SendEmailSettings = ({ options, onOptionsChange }: Props) => {
   }
 
   const handleCcChange = (ccStr: string) => {
-    const cc: string[] = ccStr.split(',').map((str) => str.trim())
+    const cc: string[] = ccStr
+      .split(',')
+      .map((str) => str.trim())
+      .filter(isNotEmpty)
     onOptionsChange({
       ...options,
       cc,
@@ -53,7 +57,10 @@ export const SendEmailSettings = ({ options, onOptionsChange }: Props) => {
   }
 
   const handleBccChange = (bccStr: string) => {
-    const bcc: string[] = bccStr.split(',').map((str) => str.trim())
+    const bcc: string[] = bccStr
+      .split(',')
+      .map((str) => str.trim())
+      .filter(isNotEmpty)
     onOptionsChange({
       ...options,
       bcc,
diff --git a/apps/docs/docs/editor/blocks/integrations/email.mdx b/apps/docs/docs/editor/blocks/integrations/email.mdx
index 67014be87..e6bda5463 100644
--- a/apps/docs/docs/editor/blocks/integrations/email.mdx
+++ b/apps/docs/docs/editor/blocks/integrations/email.mdx
@@ -10,7 +10,7 @@ If you want to receive an email notification each time a user completes the bot
   alt="Email block example"
 />
 
-By default, the email will be sent from notifications@typebot.io with default content based on what your new lead has replied to. It will look like this:
+By default, the email will be sent from `notifications@get-typebot.com` with default content based on what your new lead has replied to. It will look like this:
 
 <img
   src="/img/blocks/integrations/default-email.png"
@@ -20,6 +20,10 @@ By default, the email will be sent from notifications@typebot.io with default co
 You can choose to use your email (SMTP) account, using the "From:" dropdown and filling in your credentials.
 You can also customize the email content with your text/HTML.
 
+## Attachments
+
+You can attach files to your email with the Attachments option. Make sure that it points to a variable that is linked to a File upload input block.
+
 ## Troubleshooting
 
 You are supposed to receive an email but it doesn't get to your inbox? Make sure to check the [logs](/editor/results). If you still can't figure out what went wrong, shoot me a message using the chat button directly in the tool 👍
diff --git a/apps/docs/docs/embed/html-javascript.md b/apps/docs/docs/embed/html-javascript.md
index 90a5c4b29..45868d93f 100644
--- a/apps/docs/docs/embed/html-javascript.md
+++ b/apps/docs/docs/embed/html-javascript.md
@@ -135,3 +135,5 @@ Typebot.initContainer('typebot-container', {
 ```
 
 It will populate the `Current URL` variable with the parent URL and the `User name` variable with "John Doe".
+
+Note that if your site URL contains query params (i.e. https://typebot.io?name=John), the variables will automatically be injected to the typebot. So you don't need to manually transfer query params to the bot embed configuration.