From 2b36cedb7bce77e932285a83923c3459d3e9539d Mon Sep 17 00:00:00 2001
From: Baptiste Arnaud <contact@baptiste-arnaud.fr>
Date: Mon, 6 Feb 2023 08:44:43 +0100
Subject: [PATCH] :bug: Fix searchable dropdown z-index issues

Closes #288
---
 .../src/components/SearchableDropdown.tsx     | 73 ++++++++++---------
 .../logic/typebotLink/typebotLink.spec.ts     |  1 +
 2 files changed, 40 insertions(+), 34 deletions(-)

diff --git a/apps/builder/src/components/SearchableDropdown.tsx b/apps/builder/src/components/SearchableDropdown.tsx
index 056066172..68246b235 100644
--- a/apps/builder/src/components/SearchableDropdown.tsx
+++ b/apps/builder/src/components/SearchableDropdown.tsx
@@ -9,6 +9,7 @@ import {
   HStack,
   useColorModeValue,
   PopoverAnchor,
+  Portal,
 } from '@chakra-ui/react'
 import { Variable } from 'models'
 import { useState, useRef, useEffect, ChangeEvent, ReactNode } from 'react'
@@ -194,40 +195,44 @@ export const SearchableDropdown = ({
             )}
           </HStack>
         </PopoverAnchor>
-        <PopoverContent
-          maxH="35vh"
-          overflowY="scroll"
-          role="menu"
-          w="inherit"
-          shadow="lg"
-        >
-          {filteredItems.length > 0 && (
-            <>
-              {filteredItems.map((item, idx) => {
-                return (
-                  <Button
-                    ref={(el) => (itemsRef.current[idx] = el)}
-                    minH="40px"
-                    key={idx}
-                    onClick={handleItemClick(
-                      typeof item === 'string' ? item : item.value
-                    )}
-                    fontSize="16px"
-                    fontWeight="normal"
-                    rounded="none"
-                    colorScheme="gray"
-                    role="menuitem"
-                    variant="ghost"
-                    bg={keyboardFocusIndex === idx ? bg : 'transparent'}
-                    justifyContent="flex-start"
-                  >
-                    {typeof item === 'string' ? item : item.label}
-                  </Button>
-                )
-              })}
-            </>
-          )}
-        </PopoverContent>
+        <Portal>
+          <PopoverContent
+            maxH="35vh"
+            overflowY="scroll"
+            role="menu"
+            w="inherit"
+            shadow="lg"
+            onMouseDown={(e) => e.stopPropagation()}
+            onPointerDown={(e) => e.stopPropagation()}
+          >
+            {filteredItems.length > 0 && (
+              <>
+                {filteredItems.map((item, idx) => {
+                  return (
+                    <Button
+                      ref={(el) => (itemsRef.current[idx] = el)}
+                      minH="40px"
+                      key={idx}
+                      onClick={handleItemClick(
+                        typeof item === 'string' ? item : item.value
+                      )}
+                      fontSize="16px"
+                      fontWeight="normal"
+                      rounded="none"
+                      colorScheme="gray"
+                      role="menuitem"
+                      variant="ghost"
+                      bg={keyboardFocusIndex === idx ? bg : 'transparent'}
+                      justifyContent="flex-start"
+                    >
+                      {typeof item === 'string' ? item : item.label}
+                    </Button>
+                  )
+                })}
+              </>
+            )}
+          </PopoverContent>
+        </Portal>
       </Popover>
     </Flex>
   )
diff --git a/apps/builder/src/features/blocks/logic/typebotLink/typebotLink.spec.ts b/apps/builder/src/features/blocks/logic/typebotLink/typebotLink.spec.ts
index 2437e1eb9..09c0f1731 100644
--- a/apps/builder/src/features/blocks/logic/typebotLink/typebotLink.spec.ts
+++ b/apps/builder/src/features/blocks/logic/typebotLink/typebotLink.spec.ts
@@ -50,6 +50,7 @@ test('should be configurable', async ({ page }) => {
 
   await page.click('[aria-label="Close"]')
   await page.click('text=Jump to Start in My link typebot 2')
+  await page.waitForTimeout(1000)
   await page.click('input[value="My link typebot 2"]', { clickCount: 3 })
   await page.press('input[value="My link typebot 2"]', 'Backspace')
   await page.click('button >> text=My link typebot 1')